-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assimilate rspec questionwriter into fppgen #32
Draft
nelson-lojo
wants to merge
18
commits into
main
Choose a base branch
from
integrate-rspec-questionwriter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit babc6df Author: Nelson Lojo <[email protected]> Date: Thu May 30 18:06:02 2024 -0700 upstreaming pre/post text fixes
I am going to hold off on review till #31 closes. Meanwhile, before closing, would also like to squash this so we keep the repo history clean |
Yes I do agree that this should be a squash merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on #31. Can be marked as "not draft" once that is closed
Added most (if not all) functionality of rspec-questionwriter into fppgen.
## test ##
as yaml. As of now, this includes only thesubmit_to
andmutations
YAML fields.## setup_code ##
region## test ##
,## metadata ##
, or another region, let me knowExample source file (port of
example_question
from rspec-questionwriter) is below:example_question.fpp